build: migrate from setup.py to pyproject.toml #1458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
rgaiacs
requested changes
Aug 25, 2025
Contributor
rgaiacs
left a comment
rgaiacs
left a comment
There was a problem hiding this comment.
This looks a great start. All the tests are failing, probably because of the new test. Can change in the GitHub actions configuration be change to increase the version of Python to be used?
removes: - MANIFEST.in (handled by setuptools-scm) - setup.py (declarative in pyproject.toml) - versioneer (replaced with setuptools-scm) - setup.cfg (was for versioneer)
# Conflicts: # .github/workflows/release.yml
Member
|
@rgaiacs if you want to have a look, I think this might be ready now |
rgaiacs
approved these changes
Oct 22, 2025
Contributor
rgaiacs
left a comment
rgaiacs
left a comment
There was a problem hiding this comment.
A few minor comments. Looks good to me.
Contributor
|
test (24.04, 3.13, conda) is taking too long to finish and failing. |
Member
|
That test normally takes about 15 minutes, so I think something's definitely wrong, but likely not related to this PR. |
Member
|
latest run succeeded in 12 minutes. We should probably have a per-test limit, though, to avoid this problem costing us 6 hours of CI time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves dependency management, IDE support, and aligns with current Python packaging standards.